fix: add nil check for os.Stdout to prevent panic on Windows services#275
Merged
fatih merged 3 commits intofatih:mainfrom Mar 20, 2026
Merged
Conversation
Signed-off-by: majiayu000 <1835304752@qq.com>
fatih
pushed a commit
that referenced
this pull request
Feb 1, 2026
Comprehensive analysis of open issues and PRs with prioritization: - Critical: Windows service panic fix (PR #275), new release needed - High: VS Code color detection issues, NO_COLOR runtime behavior - Medium: tabwriter compatibility docs, hyperlink support, performance opt - Maintenance: 4 dependabot PRs pending https://claude.ai/code/session_01YJ5Uw2RTABLo4Cx4Jmzmua
Problem: The nil-safe writer helpers in this PR are named and , which reads like package init work instead of standard stream accessors. The related docs also still describe the old defaults. Solution: Rename the helpers to and , and update the nearby doc comments so and describe the actual default writers.
Owner
|
@majiayu000 thank you for your fix. I pushed an additional test and renamed some of the functions. Going to merge it as it. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #250
Changes